Skip to content

Conversation

@isuniverseok-ua
Copy link

Problem

Skript’s block data expression does not support Bukkit 'FallingBlock' entities. Users must spawn a falling block with an itemtype to carry the desired data and cannot change it afterward through the expression.

Solution

Extended 'ExprBlockData' to accept entities so FallingBlock can be targeted. Added getters, setters for the same.

Testing Completed

Local build completed successfully, no unit/integration test needed coz the issue is small and just need targeted extension using existing Bukkit API and was validated via compilation.

Supporting Information

No breaking changes expected; existing behavior for blocks and displays is unchanged. Version gating for displays remains intact.


Completes: fixes #8258
Related: none

@isuniverseok-ua isuniverseok-ua requested a review from a team as a code owner October 29, 2025 17:00
@isuniverseok-ua isuniverseok-ua requested review from Absolutionism and cheeezburga and removed request for a team October 29, 2025 17:00
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 29, 2025
@sovdeeth sovdeeth changed the base branch from master to dev/feature October 29, 2025 17:09
@isuniverseok-ua
Copy link
Author

@sovdeeth these CI build failures are unrelated to the change right?, i was not running network platform tests on my forked branch

@APickledWalrus
Copy link
Member

These CI build failures are unrelated to the change right?, i was not running network platform tests on my forked branch

There are ongoing GitHub issues that are likely the cause of the failures. We can rerun the tests later when GitHub service is restored/stable.

@isuniverseok-ua
Copy link
Author

These CI build failures are unrelated to the change right?, i was not running network platform tests on my forked branch

There are ongoing GitHub issues that are likely the cause of the failures. We can rerun the tests later when GitHub service is restored/stable.

cool

Copy link
Contributor

@Absolutionism Absolutionism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a test to ensure your addition works, and continues to work in the future.,
You can create a new test structure inside the ExprBlockData.sk test file

@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to set block data of a falling block

4 participants