-
-
Notifications
You must be signed in to change notification settings - Fork 414
feat: setting block data on FallingBlock #8261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
feat: setting block data on FallingBlock #8261
Conversation
Signed-off-by: Arnesh Dadhich <[email protected]>
|
@sovdeeth these CI build failures are unrelated to the change right?, i was not running network platform tests on my forked branch |
There are ongoing GitHub issues that are likely the cause of the failures. We can rerun the tests later when GitHub service is restored/stable. |
cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a test to ensure your addition works, and continues to work in the future.,
You can create a new test structure inside the ExprBlockData.sk test file
Problem
Skript’s block data expression does not support Bukkit 'FallingBlock' entities. Users must spawn a falling block with an itemtype to carry the desired data and cannot change it afterward through the expression.
Solution
Extended 'ExprBlockData' to accept entities so FallingBlock can be targeted. Added getters, setters for the same.
Testing Completed
Local build completed successfully, no unit/integration test needed coz the issue is small and just need targeted extension using existing Bukkit API and was validated via compilation.
Supporting Information
No breaking changes expected; existing behavior for blocks and displays is unchanged. Version gating for displays remains intact.
Completes: fixes #8258
Related: none