Skip to content

Conversation

@Absolutionism
Copy link
Contributor

Problem

There is no way for addons to be able to use container objects, such as SkriptQueue, and to to be used in ExprElements.

Solution

Adds a property handler, ElementHandler, allowing to get elements from an object, with either a specific index or a range.
Adds a property, ELEMENTS, that is used on SkriptQueue
Adds a property handler, ReturnablePropertyHandler that pulls out 'returnType' and 'possibleReturnTypes' from 'ExpressionPropertyHandler'
'ExpressionPropertyHandler' and 'ElementHandler' extend 'ReturnablePropertyHandler'
Pulls out 'getPropertyReturnTypes' from 'PropertyBaseExpression' to 'PropertyBaseSyntax',
Adds an additional 'getPropertyReturnTypes' for a handler extending 'ReturnablePropertyHandler'

Adds PropExprElements that is a property version of ExprElements.

Testing Completed

quickTest

Supporting Information

N/A

Note
PR currently fails due to pattern conflicts from property syntax elements.
This PR will stay in draft until properties are officially released in 2.14


Completes: none
Related: none

@sovdeeth
Copy link
Member

sovdeeth commented Oct 28, 2025

Haven't looked at code, but I would like the property to be called ORDERED_ELEMENTS as some things could have elements without ordered access.

Actually maybe order implies sorting, idk. Something that makes it clear you can access elements by index.

@Absolutionism Absolutionism added the 2.14 Targeting a 2.14.X version release. label Nov 2, 2025
@Absolutionism Absolutionism moved this to In Review in 2.14 Releases Nov 2, 2025
@Absolutionism Absolutionism added the feature Pull request adding a new feature. label Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.14 Targeting a 2.14.X version release. feature Pull request adding a new feature.

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants