Skip to content

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Aug 1, 2025

Problem

There are some random debug broadcasts, and tests that broadcast, some tests printing warnings. The End world is generating when it doesn't need to be, been meaning to remove that since I added the resources similarly to the nether being disabled, and there are some missing default lang nodes.

Solution

To fix the tests, add a bukkit.yml to avoid generating the end so that the boolean is set to false, and add the missing default lang nodes. The extra broadcasts and the end generating aren't needed because they just slow down the tests. Increases the gradle memory, ensures to not include skript-aliases project when building. Also fixes missing gradle tasks in the category:

Skript tasks
------------
checkAliases - Checks for the existence of the aliases.
genNightlyDocs - Generates the Skript documentation website html files.
genReleaseDocs - Generates the Skript documentation website html files for a release.
JUnit - Runs JUnit tests on all environments.
JUnitJava17 - Runs JUnit tests on all Java 17 environments.
JUnitJava21 - Runs JUnit tests on all Java 21 environments.
JUnitQuick - Runs JUnit tests on one environment being the latest supported Java and Minecraft.
quickTest - Runs tests on one environment being the latest supported Java and Minecraft.
quickTests - Runs quick test and junit quick.
skriptProfile - Starts the testing server with JProfiler support.
skriptTest - Runs tests on all environments.
skriptTestDev - Runs testing server and uses 'system.in' for command input, stop server to finish.
skriptTestJava17 - Runs tests on all Java 17 environments.
skriptTestJava21 - Runs tests on all Java 21 environments.

Completes: none
Related: none

@TheLimeGlass TheLimeGlass requested review from a team as code owners August 1, 2025 11:16
@TheLimeGlass TheLimeGlass requested review from UnderscoreTud and Efnilite and removed request for a team August 1, 2025 11:16
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Aug 1, 2025
@TheLimeGlass TheLimeGlass changed the title Fix up some tests and remove the_end Fix up some tests, remove the_end, gradle cleaning, testing env fixes Aug 1, 2025
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 1, 2025
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the end was being used for a few tests. What's the reasoning behind removing it, just that it makes the tests take a second longer? I think having 2 worlds to access during tests is more useful than saving a second or so.

@TheLimeGlass TheLimeGlass requested a review from sovdeeth August 11, 2025 14:03
@TheLimeGlass
Copy link
Contributor Author

It seems the end was being used for a few tests. What's the reasoning behind removing it, just that it makes the tests take a second longer? I think having 2 worlds to access during tests is more useful than saving a second or so.

There's no need to be having it around using extra space.

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to request that the end is kept around for testing purposes. The space and time overheads of having it are negligible, and I think the benefit for testing is useful and practical.

@sovdeeth sovdeeth removed this from 2.12 Releases Sep 8, 2025
@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. needs reviews A PR that needs additional reviews
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants