-
-
Notifications
You must be signed in to change notification settings - Fork 403
Fix up some tests, remove the_end, gradle cleaning, testing env fixes #8103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/patch
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the end was being used for a few tests. What's the reasoning behind removing it, just that it makes the tests take a second longer? I think having 2 worlds to access during tests is more useful than saving a second or so.
src/test/skript/tests/syntaxes/expressions/ExprVectorBetweenLocations.sk
Outdated
Show resolved
Hide resolved
There's no need to be having it around using extra space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to request that the end is kept around for testing purposes. The space and time overheads of having it are negligible, and I think the benefit for testing is useful and practical.
Problem
There are some random debug broadcasts, and tests that broadcast, some tests printing warnings. The End world is generating when it doesn't need to be, been meaning to remove that since I added the resources similarly to the nether being disabled, and there are some missing default lang nodes.
Solution
To fix the tests, add a bukkit.yml to avoid generating the end so that the boolean is set to false, and add the missing default lang nodes. The extra broadcasts and the end generating aren't needed because they just slow down the tests. Increases the gradle memory, ensures to not include skript-aliases project when building. Also fixes missing gradle tasks in the category:
Completes: none
Related: none