Ensure connection is active before initializing addon #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a connection may not have any channel. In this case,
ChannelAttributes.getOrCreateCommonChannels
shouldn't be called because it creates aNullPointerException
. If the channel isnull
, it should just not continue with collecting channels and initializing it for the addon.Maybe, we should also not check
isConnected
but insteadisConnecting
sinceisConnected
also checks forChannel#isOpen
andisConnecting
only checks ifchannel
is null.