-
Notifications
You must be signed in to change notification settings - Fork 70
Feature: Additional Note attributes #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panaaj
wants to merge
17
commits into
SignalK:master
Choose a base branch
from
panaaj:Notes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6a7fc2b
Add `group` and `author` attributes to Notes schema
panaaj 9470675
Additional `Note` attributes `readOnly` & `published`
panaaj f4b80a7
Updated `region`, `position` and `geohash` property descriptions to a…
panaaj c4fcc23
Updated `authors` property to align to `package.json` `contributors` …
panaaj 3cd382f
Added `properties` attribute to hold application / use case specific …
panaaj f461b55
Added example notes to test/data/full-valid
panaaj 6541493
Fix geohash values in test/data/full-valid
panaaj f87f37e
Add author definition and use for note authors property
panaaj 2da0b36
re-position #definitions section
panaaj cd8220f
Added Notes document
panaaj a219372
Update sample
panaaj ed8d1b7
add timestamp to sample
panaaj e587e71
update sample
panaaj 6b12cf3
Updated sample
panaaj d05d1f0
Added `vessels` to sample
panaaj 05c326e
update schema to require `anyOf` `region`, `geohash`, `position`
panaaj ef4a0f2
remove `anyOf` requirement for `position`, `region`, `geohash` to ret…
panaaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.