Skip to content

[tmp] hard-code debug task #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jesse-shopify wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

[tmp] hard-code debug task #758

jesse-shopify wants to merge 71 commits into from

Conversation

@jesse-shopify
Copy link

@jesse-shopify jesse-shopify commented Nov 19, 2025

Motivation

Test plan

See included automated tests.

@jesse-shopify Graphite App
Copy link
Author

jesse-shopify commented Nov 19, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jesse-shopify jesse-shopify mentioned this pull request Nov 19, 2025
Draft
@jesse-shopify jesse-shopify force-pushed the Alex/rip-wq branch 2 times, most recently from 1e4a5d1 to f8b44c0 Compare November 21, 2025 18:12
@jesse-shopify jesse-shopify force-pushed the Alex/rip-wq branch 4 times, most recently from c462b65 to 79dfe7a Compare November 26, 2025 22:47
This was referenced Nov 26, 2025
Draft
Draft
@jesse-shopify jesse-shopify force-pushed the Alex/rip-wq branch 2 times, most recently from 206c921 to 56f9a6d Compare December 1, 2025 19:07
This was referenced Dec 2, 2025
Draft
Draft
amomchilov and others added 15 commits December 2, 2025 13:51
@amomchilov @jesse-shopify
Extract computeSendLoc() helper
d7d5c7e
@amomchilov @jesse-shopify
Fix lambda Send locations
ce9d8a9
@amomchilov @jesse-shopify
Fix lambda Block locations
9ec3442
@amomchilov @jesse-shopify
[WIP] End-to-end Desugar tests
69d73f2
@amomchilov @jesse-shopify
Actually do the comparison
ede7760
@amomchilov @jesse-shopify
wip
a2b7dd8
@amomchilov @jesse-shopify
Fix Regexp desugared content location
33f04ec
@amomchilov @jesse-shopify
wip
1300523
@amomchilov @jesse-shopify
[tmp] hard-code debug task
4c5e8dd
@amomchilov @jesse-shopify
Add fallback to legacy pipeline
2e78c25 
Co-authored-by: Jesse Johnson <[email protected]>
@amomchilov @jesse-shopify
Delete directDesugar dead code
a747376 
Co-authored-by: Jesse Johnson <[email protected]>
@amomchilov @jesse-shopify
Delete directlyDesugar checks
5d651f0 
Co-authored-by: Jesse Johnson <[email protected]>
@amomchilov @jesse-shopify
Delete remaining directlyDesugar uses
5428350 
Co-authored-by: Jesse Johnson <[email protected]>
@amomchilov @jesse-shopify
Rework hasExpr() into enforceHasExpr checkpoint 1
36688f1 
Co-authored-by: Jesse Johnson <[email protected]>
@amomchilov @jesse-shopify
Rework hasExpr() into enforceHasExpr checkpoint 2
04ee5bf 
Co-authored-by: Jesse Johnson <[email protected]>
jesse-shopify and others added 29 commits December 2, 2025 13:51
@jesse-shopify
PM_INSTANCE_VARIABLE_READ_NODE PM_INSTANCE_VARIABLE_TARGET_NODE retur…
8e58acd 
…n expr_only
@jesse-shopify
PM_GLOBAL_VARIABLE_READ_NODE, PM_GLOBAL_VARIABLE_TARGET_NODE return e…
3231327 
…xpr_only
@jesse-shopify
PM_IMAGINARY_NODE return expr_only
abd20be
@jesse-shopify
PM_IMPLICIT_REST_NODE return expr_only
dbbf3bc
@jesse-shopify
PM_KEYWORD_REST_PARAMETER_NODE return expr_only
3e9de76
@jesse-shopify
PM_LOCAL_VARIABLE_READ_NODE, PM_LOCAL_VARIABLE_TARGET_NODE return exp…
ca0fb8b 
…r_only
@jesse-shopify
PM_NIL_NODE return expr_only
1bb66ba
@jesse-shopify
PM_NUMBERED_REFERENCE_READ_NODE return expr_only
23bdaa0
@jesse-shopify
PM_OPTIONAL_KEYWORD_PARAMETER_NODE, PM_OPTIONAL_PARAMETER_NODE return…
b36a588 
… expr_only
@jesse-shopify
PM_RANGE_NODE return expr_only
1210019
@jesse-shopify
PM_RATIONAL_NODE return expr_only
0e3f5d7
@jesse-shopify
PM_REQUIRED_KEYWORD_PARAMETER_NODE, PM_REQUIRED_PARAMETER_NODE return…
640b0f2 
… expr_only
@jesse-shopify
PM_REST_PARAMETER_NODE return expr_only
1f85940
@jesse-shopify
PM_RETRY_NODE return expr_only
9832e37
@jesse-shopify
PM_SELF_NODE return expr_only
ed02319
@jesse-shopify
PM_SINGLETON_CLASS_NODE return expr_only
65a1762
@jesse-shopify
PM_SOURCE_ENCODING_NODE, PM_SOURCE_FILE_NODE, PM_SOURCE_LINE_NODE ret…
e69e8ba 
…urn expr_only
@jesse-shopify
PM_WHILE_NODE, PM_UNTIL_NODE return expr_only
a3b314c
@jesse-shopify
add desugarBreakNextReturn to handle those cases
abe42a6 
add desugarArguments helper
PM_BREAK_NODE, PM_NEXT_NODE, PM_RETURN_NODE are refactored to called to desugarBreakNextReturn and return expr_only
@jesse-shopify
PM_YIELD_NODE returns expr_only
f0db2df
@jesse-shopify
PM_X_STRING_NODE returns expr_only
0cbc718
@jesse-shopify
PM_INDEX_TARGET_NODE returns expr_only
8e6cc81
@jesse-shopify @KaanOzkan
@st0012 @thomasmarshall @allcre
PM_ARRAY_NODE returns expr_only
8d6ac8f 
Co-authored-by: Kaan Ozkan <[email protected]>
Co-authored-by: Stan Lo <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Allison Cretel <[email protected]>
@jesse-shopify
replace 2 cases of desugarArguments with nodeListToStore
9e5c823
@jesse-shopify @KaanOzkan
PM_UNDEF_NODE returns expr_only
80e9430 
Co-authored-by: Kaan Ozkan <[email protected]>
@jesse-shopify @KaanOzkan
PM_EMBEDDED_STATEMENTS_NODE returns expr_only
036fdcb 
Co-authored-by: Kaan Ozkan <[email protected]>
@jesse-shopify @KaanOzkan
PM_PARENTHESES_NODE returns expr_only
04c5d60 
Co-authored-by: Kaan Ozkan <[email protected]>
@jesse-shopify
PM_STATEMENTS_NODE returns expr_only
bd49daa
@jesse-shopify
Use takeDesugaredExprOrEmptyTree where possible
8dfe159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jesse-shopify @amomchilov