Rx search view #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taeho Kim <[email protected]>
Fix order of modifiers in ViewEvent
Guard against null in ViewEvent
…laky Fix RxSwipeDismissBehavior flaky test
Remove explicit 'public' modifier from Kotlin code.
This ensures that synchronous unsubscription (like take(1)) does not leak the listener onto the view.
Because other artifacts might depend on older versions of support-v4, force them to the current version so that normal resolution semantics apply properly.
Switch TargetApi for more correct RequiresApi annotation.
Add listeners after setting the unsubscribe action.
Depend only on the Core UI artifact from support-v4.
…rch-view * 'master' of github.com:JakeWharton/RxBinding: Add BottomNavigationView binding Depend only on the Core UI artifact from support-v4. Add listeners after setting the unsubscribe action. Switch TargetApi for more correct RequiresApi annotation. Remove explicit 'public' modifier from Kotlin code. Add support for View key event binding change swipe speed to FAST to fix flaky test Guard against null in ViewEvent Add new SlidingPaneLayout bindings Fix order of modifiers in ViewEvent Added currentItem action to RxViewPager Add ViewPager page scroll state change binding # Conflicts: # rxbinding-appcompat-v7-kotlin/src/main/kotlin/com/jakewharton/rxbinding/support/v7/widget/RxSearchView.kt # rxbinding-kotlin/src/main/kotlin/com/jakewharton/rxbinding/widget/RxSearchView.kt
farshadjanu1
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge code from master.
The idea is to continue this branch so it can be merged latter in JakeWharton#213.