I worked on add 16Bit IN/OUT #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and Splits arent working yet
|
damn i didnt know you were an editor i was reviewing changes |
|
what i didn't close this i was trying to merge new updates and accedentaly pushed that pr here so i closed that not this one |
sk337
reviewed
May 5, 2025
| }catch (Exception e){ | ||
| Debug.Log(e); | ||
| if (stringFormat is DataDisplayMode.Binary){ | ||
| uintVal =(uint) ((ulong) (Convert.ToInt64(displayString, 2))& 0b11111111111111111111111111111111); |
There was a problem hiding this comment.
could you either replace this with 0xFFFFFFFF or a constant like UINT32_MAX
There was a problem hiding this comment.
i changed it to 0xFFFFFFFF
The only issue is special charachters are just blank plus 128-255 is also blank
Works with Ascii 8bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 16 Bit In/Out as it makes more sense for the ROM256x16 to be a 16Bit out instead of 2 8Bit or it could be a choice for someone for which one to use. I also added a RGBLED but it is very large as there are 8Bit Inputs so there is 0 to 255 range for each RED, GREEN, and BLUE.