Skip to content

Conversation

UkrainianBanderasCat
Copy link
Contributor

@UkrainianBanderasCat UkrainianBanderasCat commented Apr 17, 2025

This PR adds notes, that can be edited. Still in progress

Screenshot 2025-04-17 at 20 23 08

UPD:

Made new design. Notes color can now be chosen and notes text can now be edited.
This was requested in #282 and also other users of Digital Logic Sim
Screenshot 2025-04-18 at 16 54 41
Screenshot 2025-04-18 at 16 57 53

@UkrainianBanderasCat UkrainianBanderasCat marked this pull request as ready for review April 18, 2025 20:14
@SebLague
Copy link
Owner

This is looking very cool, but my crude text system needs some work before it can handle this multi-line stuff properly. Mouse selection, arrow keys, ctrl+A to select all, etc. all don't function correctly here. Line wrap is also not well-behaved (splits words, and adds space on new line unnecessarily)

@UkrainianBanderasCat
Copy link
Contributor Author

This is looking very cool, but my crude text system needs some work before it can handle this multi-line stuff properly. Mouse selection, arrow keys, ctrl+A to select all, etc. all don't function correctly here. Line wrap is also not well-behaved (splits words, and adds space on new line unnecessarily)

So what to do now? I can continue working on fixing this problems and improving text area

@SebLague
Copy link
Owner

You're welcome to dive into the text system and fix these issues yourself if you wish to, otherwise you can wait until I have time to do it (but might take a while).

@UkrainianBanderasCat
Copy link
Contributor Author

UkrainianBanderasCat commented Apr 19, 2025

You're welcome to dive into the text system and fix these issues yourself if you wish to, otherwise you can wait until I have time to do it (but might take a while).

Ok, I will try, and thank you for feedback:)

@logic-mindful
Copy link
Contributor

Also suggested in #510

BeboKhouja and others added 29 commits June 16, 2025 17:38
Fix for display of 32bit pins and higher
For compatibility issues with previously created projects
Fix bugs with my chips and add new bit counts
Custom pin layouts on Subchips
Adaptations of Dom's custom pin layouts for higher bitcount + snap
otherwise it breaks preexisting projects bruh
Forgot to fix EEPROM write
Confirms when a pin size is added
Adds the option to close without saving just in case.
Now, closing without saving actually closes without saving.
Saving only happens when saving.
Quick bugfix, also removes clutter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants