Skip to content

Contributing enhancements #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

alinacherkas
Copy link
Contributor

Description

This request enhances the developer's experience and streamlines the contributing process by adding renv and extending the contributing guidelines.

Main Changes

  • Configure the project to use renv which isolates the developer's environment
  • Detail how to contribute to the project in contributing guidelines
  • Update .gitignore using the modern GitHub template for R projects

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have updated the documentation where applicable.

Additional Context

None.

@SebKrantz
Copy link
Owner

SebKrantz commented Feb 26, 2025

Thanks @alinacherkas. I'm wondering though, I presume it is still possible to contribute in the classical way? If people have to install renv to contribute to collapse (which frankly I haven't used myself all the years), it may make it more difficult to do so?

@alinacherkas
Copy link
Contributor Author

Hi @SebKrantz, actually, installation is not even necessary these days. According to renv documentation:

Now when one of your collaborators opens this project, renv will automatically bootstrap itself, downloading and installing the appropriate version of renv.

I have already verified this on another device and removed the note from CONTRIBUTING.md.

renv's main benefit is that all the packages (testthat, plm and other packages under Suggests) are installed in an isolated environment. Additionally, you can easily upgrade all the packages with renv::update() for testing before releasing to CRAN.

You don't really have to do much to use renv in this case. One can just open .Rproj and work the usual way.

@SebKrantz
Copy link
Owner

Ok, thanks. I'll test this on your fork during the weekend - it's not a small change to the repo and I need to ensure myself and others can work without problems with it - even using VScode and other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants