Skip to content

Fixes stuck construct process in Sim and Novice Areas #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixes stuck construct process in Sim and Novice Areas #441

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a04213
Construct process would get stuck if it couldn't remove certain struc…
alexanselmo Nov 28, 2020
85ecf71
Update construct.js
alexanselmo Nov 28, 2020
97df6c9
More linting
alexanselmo Nov 28, 2020
74cbfd3
We can't remove things that don't have a defined hits value, includin…
alexanselmo Nov 28, 2020
fc573d6
better formating for longer comment
alexanselmo Nov 28, 2020
431e690
Update construct.js
alexanselmo Nov 28, 2020
d605282
more linting.
alexanselmo Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/programs/city/construct.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class CityConstruct extends kernel.process {
const miningPositions = this.room.find(FIND_SOURCES).map(s => s.getMiningPosition())
this.data.hascleared = true
for (const structure of structures) {
if (structure.structureType === STRUCTURE_CONTROLLER) {
// Skips things that can't be removed, I.E. Controllers, Novice area walls, SK lair (can break sim)
if (structure.hits === undefined) {
continue
}
if (structure.my) {
Expand Down