FREYA-1693: Add multi-disease serology dashboard #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new entry in `dashboards/index.html` - Add new url in `dashboards/urls.py`
To future proof the dashboards views and avoid clutter, it's better to organise them within a views package. They are individually imported in `__init__.py` to provide a single generic import endpoint to the `urls.py` module.
senthil10
requested changes
Oct 13, 2025
There was a problem hiding this comment.
Only had a quick view since something might change after our meeting. Mainly requesting changes at the moment to exclude format fixes in citation and data-management pages (apps).
I also noticed there were pagination for tables at the moment, maybe you left it out to be fixed later along with the styles (?)
misterabdullahAziz
requested changes
Oct 13, 2025
pages/dashboards/templates/dashboards/multidisease_serology.html
Outdated
Show resolved
Hide resolved
pages/dashboards/templates/dashboards/multidisease_serology.html
Outdated
Show resolved
Hide resolved
Ziip-dev
force-pushed
the
FREYA-1693/Paul/dashboard-serology
branch
2 times, most recently
from
e916013 to
17686a5
Compare
|
Done addressing your comments! Hopefully I didn't forget anything, otherwise let me know :) |
Ziip-dev
force-pushed
the
FREYA-1693/Paul/dashboard-serology
branch
from
17686a5 to
324e7f5
Compare
|
Removed hyphenation changes as per #27 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR adds the multi-disease serology dashboard and switch the dashboard app to a views package pattern for future proofing.
Although the implementation works for now, its current state is temporary as it will be partly reworked in the future when we will have a proper data storage solution,
Celeryfor async jobs andhtmxfor front-end interactivity.🛠️ Changes Made
multidisease_serologyviewbase.css🔍 Notes for Reviewers
Just ensure that the multi-disease serology dashboard looks ok at
http://localhost:8000/dashboards/multidisease-serology/.The tables will be improved once we have
htmx.✅ Checklist
FREYA-XXXX: Clear and short description🔗 Jira Issue
Closes: FREYA-1693