Skip to content

Remove nonlinearsolve as a dep by just using the default nonlinearsolve #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChrisRackauckas
Copy link
Member

Should greatly improve load times when it's not needed.

Copy link
Contributor

github-actions bot commented Jul 28, 2025

Benchmark Results (Julia v1)

Time benchmarks
master 272f68a... master / 272f68a...
ODEProblem 0.0833 ± 0.0049 s 0.0832 ± 0.0047 s 1 ± 0.082
init 0.0577 ± 0.012 ms 0.057 ± 0.012 ms 1.01 ± 0.31
large_parameter_init/ODEProblem 0.742 ± 0.027 s 0.755 ± 0.017 s 0.983 ± 0.042
large_parameter_init/init 0.101 ± 0.013 ms 0.101 ± 0.012 ms 0.996 ± 0.17
mtkcompile 0.0354 ± 0.0012 s 0.0355 ± 0.0016 s 0.997 ± 0.056
time_to_load 5.95 ± 0.023 s 5.07 ± 0.012 s 1.17 ± 0.0053
Memory benchmarks
master 272f68a... master / 272f68a...
ODEProblem 0.579 M allocs: 18.9 MB 0.578 M allocs: 18.8 MB 1
init 0.815 k allocs: 0.0318 MB 0.815 k allocs: 0.0318 MB 1
large_parameter_init/ODEProblem 4.68 M allocs: 0.169 GB 4.68 M allocs: 0.169 GB 0.999
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.233 M allocs: 8.08 MB 0.232 M allocs: 8.08 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Copy link
Contributor

github-actions bot commented Jul 28, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 272f68a... master / 272f68a...
ODEProblem 0.0846 ± 0.0063 s 0.0825 ± 0.0062 s 1.03 ± 0.11
init 0.0608 ± 0.0016 ms 0.0606 ± 0.0016 ms 1 ± 0.037
large_parameter_init/ODEProblem 0.71 ± 0.011 s 0.707 ± 0.0073 s 1 ± 0.018
large_parameter_init/init 0.112 ± 0.0026 ms 0.112 ± 0.0024 ms 0.998 ± 0.032
mtkcompile 0.0361 ± 0.0014 s 0.0345 ± 0.00073 s 1.05 ± 0.046
time_to_load 5.65 ± 0.094 s 4.82 ± 0.038 s 1.17 ± 0.022
Memory benchmarks
master 272f68a... master / 272f68a...
ODEProblem 0.588 M allocs: 20 MB 0.588 M allocs: 20 MB 1
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.61 M allocs: 0.177 GB 4.63 M allocs: 0.178 GB 0.991
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.233 M allocs: 8.65 MB 0.233 M allocs: 8.63 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@ChrisRackauckas ChrisRackauckas force-pushed the nonlinearsolve_default branch from bdcf59b to 272f68a Compare July 31, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant