Skip to content

Conversation

bgoewert
Copy link
Contributor

No description provided.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

Thanks! I can merge this once CI goes green

@bgoewert
Copy link
Contributor Author

@hyperupcall There are failing checks but it seems like this is ready. Anything I need to do with the failing checks?

@hyperupcall
Copy link
Member

@bgoewert Yup, click on each CI job that's red and you can see the error output of each. With the pre-commit error for example, the formatting of the JSON files are not what is expected. You can run prettier locally to fix that. More information is in the CONTRIBUTING.md file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants