Skip to content

fix: various catalog url fixes #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: various catalog url fixes #4870

wants to merge 1 commit into from

Conversation

scop
Copy link
Contributor

@scop scop commented Jul 25, 2025

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

Thanks! I'm a little hesitant to change the primary URLs in a way that substitutes main and master for a commit or tag because it would mean they would no longer automatically stay up to date, which is a behavior that I think some authors intentionally depend on. But those cases, I'll definitely be able to accept adding those new URLs that include a tag in the versions field. The rest of the changes look great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

@hyperupcall hyperupcall Awaiting requested review from hyperupcall hyperupcall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @hyperupcall