Skip to content

Conversation

oyvindberg
Copy link
Collaborator

@oyvindberg oyvindberg commented Oct 5, 2020

So far we've been pretty pedantic in the handling of things like re-exported types.

declare module "libfoo/impl/foo" {
  export class Foo {}
}
declare module "libfoo" {
  export import {Foo} from ''libfoo/impl/foo";
  export class Bar {
    constructor(foo: Foo) {}
  }
}

In most cases Bar has pointed to libfoo.Foo so far, while the intention was really something compatible with libfoo/impl/foo.Foo

In the name of pragmatism, assert that if a class has a parent with the same name and type parameters, accept that in the place of the child class.

@oyvindberg oyvindberg changed the title Generalize type references to classes to point to the parent class as… Generalize type references Oct 5, 2020
@oyvindberg
Copy link
Collaborator Author

effect so far ScalablyTyped/Distribution@ff1c1ce

@oyvindberg oyvindberg force-pushed the generalize-typerefs branch 2 times, most recently from 27400df to 10c5a16 Compare October 5, 2020 23:40
@oyvindberg oyvindberg changed the base branch from master to scala-companion-objects November 18, 2020 23:20
@oyvindberg oyvindberg changed the base branch from scala-companion-objects to master November 18, 2020 23:20
@oyvindberg oyvindberg force-pushed the generalize-typerefs branch 2 times, most recently from 81f1a8f to bbad63e Compare November 18, 2020 23:28
@oyvindberg oyvindberg force-pushed the master branch 2 times, most recently from d3bbca8 to ad9f226 Compare November 15, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant