-
Notifications
You must be signed in to change notification settings - Fork 47
Limits python version to <3.14 #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think a bit more investigation is needed here. I have no problems installing PySide6 with Python 3.14 - I also have sasview successfully running with Python 3.14 here. One just needs to remove |
|
Hmm, this is very strange. When installing with
|
|
pip doesn't yet have PySide6 for 3.14, but conda-forge already does Maybe |
|
The wheels are tagged as So... the user trying to install with Python 3.14 can either: use Incidentally, the reason why INSTALL.md doesn't list uv currently is that I needed to land PRs quickly to fix problems in the installer and didn't feel like engaging in a protracted argument about favourite new tools to manage venvs, of which there are far too many... (There should be one-- and preferably only one --obvious way to do it.... yeah). |
|
Ok, given this discussion, and the fact that I would hope this issue is only temporary, I'm happy to not add this limit and close the issue if everyone agrees. However, I would suggest that our preferred approach is to recommend users use python 3.12 or 3.13 until PySide6 are happy themselves with using 3.14, and that @llimeht's methods are used only is someone is completely determined to use python 3.14 (and understands there is a theoretical risk issues may arise). I've started using Let me know your thoughts. |
rozyczko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and we should have this until all the (potential) kinks with 3.14 are solved.

Description
Fixes #3738. The change is ultimately academic, as the build system fails on the requirements for PySide6 before we get to the
requires-pythonsection, but I think it will be helpful for users/developers to see in SasView itself that we cannot support python 3.14 until PySide6 starts supporting it.How Has This Been Tested?
Attempted to install SasView with python 3.14. When commenting out pyopengl and pyside6 in the build system requirements, I get the desired error
ERROR: Package 'sasview' requires a different Python: 3.14.0 not in '<3.14,>=3.12'Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)