Qwedge #3601
Merged
Qwedge #3601
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butlerpd
reviewed
Nov 12, 2025
| self.data.ymax, np.fabs(self.data.ymin)) | ||
| self.dqmin = min(np.fabs(self.data.qx_data)) | ||
| self.connect = self.base.connect | ||
|
|
Member
There was a problem hiding this comment.
why do we need an extra line here
butlerpd
approved these changes
Nov 12, 2025
Member
butlerpd
left a comment
butlerpd
left a comment
There was a problem hiding this comment.
Code looks good to me with the question caveat. However conflicts need to be resolved before merging.
functionality tested on windows 11 and works as advertized. However note that the fold parameter has been removed from the Slicer Paremeter menu. I do not see how that is relevant to this pull request and will create another issue
jellybean2004
force-pushed
the
qwedge
branch
from
93cc26d to
3ffa76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the fold for Wedge Slicer to True, so the Wedge Averaging in Q does not create data in the negative Q space.
Fixes #3221
How Has This Been Tested?
Tried out a few data sets to see if the expected behaviour is produced.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)