Skip to content

Feature: Add recipe name to the node edit modal. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature: Add recipe name to the node edit modal. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d884397
Make the title of the node config modal include the recipe name.
dimani128 Aug 30, 2025
4a8936e
Remove some unnecessary css overrides.
dimani128 Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ <h2 class="title">Select a recipe <span class="game-version"></span></h2>
<div class="dimming modal-window-container hidden" id="machine-configuration-container">
<div class="modal-window">
<div class="title-row">
<h2 class="title">Node configuration</h2>
<h2 class="title">Node configuration: <span class="subtitle" id="machine-configuration-title">Recipe Name Goes Here</span></h2>
<div class="close">
<svg class="cross_icon-placeholder"></svg>
</div>
Expand Down
5 changes: 5 additions & 0 deletions dist/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,11 @@ div.modal-window {
font-weight: 500;
}

.modal-window .title-row span.subtitle {
font-weight: 100;
color: var(--dim-foreground-light);
}

.modal-window .title-row div.close {
display: flex;
align-items: center;
Expand Down
6 changes: 5 additions & 1 deletion src/Sankey/NodeConfiguration/NodeConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class NodeConfiguration extends EventTarget
});
}

public openConfigurationWindow(openingMachinesAmount: number, openingOverclockRatio: number): void
public openConfigurationWindow(recipeName: string, openingMachinesAmount: number, openingOverclockRatio: number): void
{
this._openingMachinesAmount = openingMachinesAmount;
this._openingOverclockRatio = openingOverclockRatio;
Expand Down Expand Up @@ -169,6 +169,8 @@ export class NodeConfiguration extends EventTarget

/* Modal window */

NodeConfiguration._machineConfigurationTitle.innerText = recipeName;

NodeConfiguration._modalContainer.classList.remove("hidden");

this._isOpened = true;
Expand Down Expand Up @@ -453,6 +455,8 @@ export class NodeConfiguration extends EventTarget

private static readonly _modalContainer =
document.querySelector("#machine-configuration-container") as HTMLDivElement;
private static readonly _machineConfigurationTitle =
document.querySelector("#machine-configuration-title") as HTMLDivElement;

private static readonly _machinesColumn = NodeConfiguration.getColumn("amount", "machines");
private static readonly _amountInputsColumn = NodeConfiguration.getColumn("amount", "inputs");
Expand Down
2 changes: 1 addition & 1 deletion src/Sankey/SankeyNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ export class SankeyNode extends EventTarget

let openConfigurator = (event: Event) =>
{
configurator.openConfigurationWindow(this.machinesAmount, this.overclockRatio);
configurator.openConfigurationWindow(recipe.displayName, this.machinesAmount, this.overclockRatio);
event.stopPropagation();
};

Expand Down