[serialize] prefer fc over bmm on const lhs #356
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glistening
force-pushed
the
prefer_fc_over_bmm_on_const_lhs
branch
from
2c011b1 to
75d272f
Compare
If lhs of matmul is const, emit fullyconnected instead of bmm. TICO-DCO-1.0-Signed-off-by: Sanggyu Lee <[email protected]>
glistening
force-pushed
the
prefer_fc_over_bmm_on_const_lhs
branch
from
75d272f to
9573413
Compare
This was referenced Sep 19, 2025
Contributor
Author
|
I've done using o2o. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If lhs of matmul is const, emit fullyconnected instead of bmm.
TICO-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]
NOTE: Please do not merge this PR.
Hopefully, #341 will solve the problem better. (not only bmm to fullyconnected + transpose as my PR, but to 1 fullyconnected).