Display schema column too small error in query_fileview #1633
Conversation
…mall instead of falling back to an AccessCredentialsError
|
@afwillia , is there a workaround for this? If so, we will no longer be addressing non critical bugs. @andrewelamb can you assess this? |
|
@thomasyu888 I was just looking at this. Givens the reasons Tom mentioned, I don't think this is needed. It improves the error message, but since API error messages aren't displayed to DCA users anyway through the API this really only slightly helps engineers when diagnosing. For that reason, let's drop this. |
|
@afwillia just to be clear there's nothing wrong with your solution. If we hadn't frozen DCA development this would be a fine solution. |
|
@thomasyu888 that's fine as this schema issue will raise an error either way. I imagine in most cases it shouldn't be an issue because users will check the file view on Synapse and notice the error. |
|
@thomasyu888 @andrewelamb just noting this isn't a specific issue with the REST API or DCA, that's just where I caught it. I believe this would affect CLI users as well. |
|
3 participants
Problem:
A DCA user reported a
Forbiddenerror trying to access folders within a project. This was caused by a 403 error returned from the/storage/projects/endpoint. The user and myself both had admin permission to the file view and folders, so it wasn't a 403 issue. Looking up the file view on Synapse, there was an error banner stating one of the schema columns was too short. The user rolled back the schema changes and resolved the issue.Solution:
This PR adds a
elifstatement to checkquery_fileviewerrors for the specific text returned by Synapse when a schema column is too short. Avoiding the default 403 error for this case.