Skip to content

Conversation

idbolshakov
Copy link

@idbolshakov idbolshakov commented May 24, 2023

Summary

Fix for the connect-web integration instruction

Problem description

There is a syntax error in the current instruction. undefined should not be wrapped with quotes

Pros/cons of approach implemented

not applicable for the current PR I think

Checklist

  • Is this PR a reasonable size?

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant