Skip to content

Conversation

@lvicoun
Copy link
Contributor

@lvicoun lvicoun commented Oct 22, 2025

PR creator: Description

Describe the overall goals of this pull request.

PR creator: Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#...

PR reviewer: Checklist for editorial review

Apart from the usual checks, please double-check also the following:

@lvicoun lvicoun added the WIP Work in progress. Do not merge! label Oct 22, 2025
@lvicoun lvicoun removed the WIP Work in progress. Do not merge! label Oct 24, 2025
@lvicoun lvicoun requested review from taroth21 and tomschr October 24, 2025 10:54
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvicoun Thanks, I found some inconsistencies.

<meta name="social-descr" its:translate="yes">Perform kernel live patching on &productnameshort;</meta>
<!-- suitable category, comma-separated list of categories -->
<meta name="category" content="Systems Management" its:translate="no"/>
<meta name="category" content="Update&amp;Upgrade" its:translate="no"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put it inside a <phrase> and space around the ampersand:

Suggested change
<meta name="category" content="Update&amp;Upgrade" its:translate="no"/>
<meta name="category" its:translate="no">
<phrase>Update &amp; Upgrade"</phrase>
</meta>

Comment on lines +141 to +143
<meta name="category" its:translate="no">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Maybe you meant task?

Suggested change
<meta name="category" its:translate="no">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Containerization</phrase>
<phrase>Virtualization</phrase>
</meta>

Comment on lines +107 to +109
<meta name="category" its:translate="no">
<phrase>Configuration</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a valid value according to Category (Confluence). Maybe you meant task?

Suggested change
<meta name="category" its:translate="no">
<phrase>Configuration</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Configuration</phrase>
</meta>

Comment on lines +94 to +95
<meta name="category" its:translate="no">
<phrase>Initial Configuration</phrase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

Suggested change
<meta name="category" its:translate="no">
<phrase>Initial Configuration</phrase>
<meta name="task" its:translate="no">
<phrase>Configuration</phrase>

Comment on lines -101 to +102
<phrase>Configuration</phrase>
<phrase>Installation</phrase>
<phrase>Tuning</phrase>
<phrase>Performance</phrase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither "Tuning" nor "Performance" is valid for a task.

Comment on lines +125 to +127
<meta name="category" its:translate="no">
<phrase>Deployment</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta name="category" its:translate="no">
<phrase>Deployment</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Deployment</phrase>
</meta>

Comment on lines +128 to +129
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Administration</phrase>
</meta>

Comment on lines +500 to 501
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Administration</phrase>
</meta>

Comment on lines 112 to +113
<meta name="category">
<phrase>Systems Management</phrase>
<phrase>Product Usage</phrase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "Product Usage".

Comment on lines +49 to +51
<meta name="category">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need task:

Suggested change
<meta name="category">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
<meta name="task">
<phrase>Containerization</phrase>
<phrase>Virtualization</phrase>
</meta>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants