-
Notifications
You must be signed in to change notification settings - Fork 21
Language review of the "Agama installation for SAP" article #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @lvicoun, some quick comments for this one: In this assembly, the topics are not named according to our conventions, i.e. they should contain assembly's main components, sth like agama-automated-installation-topic-1, agama-automated-installation-topic-2, etc. Also, this file is a stub: |
|
@sounix000 please ensure that the files are named correctly, it helps with the navigation a lot. Thanks! |
lvicoun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Dasha! Just minor stuff.
Co-authored-by: lvicoun <[email protected]>
Co-authored-by: lvicoun <[email protected]>
Co-authored-by: lvicoun <[email protected]>
|
@dariavladykina @lvicoun - Changes implemented in #595. This branch can get merge conflicts and things can get messy, so requesting to close this branch/PR if Daria is satisfied with the one I started. |
|
Closing this PR, as changes were implemented in #595 to avoid merge conflicts. |
Description
Language review of the article "Automated installation of SUSE Linux Enterprise Server for SAP applications using Agama".