Skip to content

Improvement of topic validation #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −0
Open

Improvement of topic validation #1471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c240bc
Updated error message in utils.js
bisand May 10, 2023
f305d77
Added numeric check for offset in topic
bisand May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ function validateTopics (topics) {
return typeof topic.partition !== 'number';
}
return false;
})) {
throw new InvalidConfigError('Partition must be a number and can not contain characters');
}
if (topics.some(function (topic) {
if ('offset' in topic) {
return typeof topic.offset !== 'number';
}
return false;
})) {
throw new InvalidConfigError('Offset must be a number and can not contain characters');
}
Expand Down