-
Notifications
You must be signed in to change notification settings - Fork 23
Ingest modeled parameters sanghi23 #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ingest modeled parameters sanghi23 #655
Conversation
This looks like great progress! Before adding new parameters, please add a test for the modeled parameters that counts the number of parameters with model = Null. |
Also update with main. It shouldn't impact this PR since it's all photometry and proper motions. |
I just edited pytest cases where I added one for checking which had a null value for model and also how many of each parameter was ingested (added one for L bol). I added counters in my script and have the number in the comments next to it and the pytest case numbers make sense when I do the math |
Just pushed the new pytest file. I have the JSON files (a little over 1000) ready to push whenever |
tests/test_data_modeled_params.py
Outdated
if len(t) > 0: | ||
print("\nEntries found without a model") | ||
print(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if statement is not needed since we expect some parameters to not have models.
if len(t) > 0: | |
print("\nEntries found without a model") | |
print(t) |
Awesome progress!
|
Did you want the pytest case to check references for each parameter or just in general? |
Short description: Include what type of data being ingested and appropriate references.
Link to relevant issue: Closes #518
For data ingests:
[ ] includes script used for ingest
[ ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table