Skip to content

Ingest modeled parameters sanghi23 #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kaseyLee123
Copy link
Contributor

Short description: Include what type of data being ingested and appropriate references.

Link to relevant issue: Closes #518

For data ingests:
[ ] includes script used for ingest
[ ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table

@kaseyLee123 kaseyLee123 changed the title basic change Ingest modeled parameters sanghi23 Jul 29, 2025
@kaseyLee123 kaseyLee123 self-assigned this Jul 30, 2025
@kelle
Copy link
Collaborator

kelle commented Jul 30, 2025

This looks like great progress! Before adding new parameters, please add a test for the modeled parameters that counts the number of parameters with model = Null.

@kelle
Copy link
Collaborator

kelle commented Jul 30, 2025

Also update with main. It shouldn't impact this PR since it's all photometry and proper motions.

@kaseyLee123
Copy link
Contributor Author

I just edited pytest cases where I added one for checking which had a null value for model and also how many of each parameter was ingested (added one for L bol). I added counters in my script and have the number in the comments next to it and the pytest case numbers make sense when I do the math

@kaseyLee123
Copy link
Contributor Author

Just pushed the new pytest file. I have the JSON files (a little over 1000) ready to push whenever

Comment on lines 11 to 13
if len(t) > 0:
print("\nEntries found without a model")
print(t)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement is not needed since we expect some parameters to not have models.

Suggested change
if len(t) > 0:
print("\nEntries found without a model")
print(t)

@kelle
Copy link
Collaborator

kelle commented Jul 30, 2025

Awesome progress!

  • could you please try to push just 10-20 JSON files. If you're still using Github Desktop, use the checkboxes to Deselect All and then Select 10-20 by hand to add, commit, and push.
  • add tests which test the references for the modeled paramaters. How many Lbols from Fili15?

@kaseyLee123
Copy link
Contributor Author

Awesome progress!

  • could you please try to push just 10-20 JSON files. If you're still using Github Desktop, use the checkboxes to Deselect All and then Select 10-20 by hand to add, commit, and push.
  • add tests which test the references for the modeled paramaters. How many Lbols from Fili15?

Did you want the pytest case to check references for each parameter or just in general?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest modeled parameters from Sanghi et al. 2023
2 participants