noptor: restart browser #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ptor/taskScheduler.js
Outdated
| var ConfigParser = require('./configParser').ConfigParser; | ||
|
|
||
| /** | ||
| * properties for parallelization and multi browser support: |
There was a problem hiding this comment.
The idea is to support only maxInstances e.g. config.maxInstances:5 would mean that up to 5 parallel sessions are started that drain the execution queue. The queue contains the list of spec.js files.
src/coreReporters/runnerReporter.js
Outdated
| // called (e.g. when fit is used) | ||
| this.startTime = new Date(); | ||
|
|
||
| browser.plugins_.addPlugin({ |
There was a problem hiding this comment.
The idea is to have a single flag, config.restartBrowserBetweenSpecs: true ( for consistent naming with config.specs and config.suites params) that will be handled in the TaskRunner. And if set, will restart the browser before taking the next task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #315