fix: auto submit payment form to the iframe #20726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matejk00
changed the title
Matejk00
changed the title
Matejk00
changed the title
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-10877
|
| Run status |
|
| Run duration | 03m 22s |
| Commit |
|
| Committer | Mateusz Kolasa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
101
|
| View all changes introduced in this branch ↗︎ | |
Merge Checks Failed |
|
|
||
| protected submitFormToIframe(): void { | ||
| if (this.isPaymentDataReady && this.formElement?.nativeElement) { | ||
| const form = this.formElement.nativeElement; |
There was a problem hiding this comment.
can we move const form inside the 'if' block so won't be created if not IFRAME?
FollowTheFlo
previously approved these changes
Sep 19, 2025
Matejk00
dismissed
FollowTheFlo’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CXSPA-10877