Skip to content

Conversation

devinea
Copy link
Member

@devinea devinea commented Sep 20, 2025

feat: integrate ux logger utility across the fiori-mcp-server package

Copy link

changeset-bot bot commented Sep 20, 2025

🦋 Changeset detected

Latest commit: c2cb9cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege added the fiori-mcp @sap-ux/fiori-mcp label Sep 20, 2025
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the PR looks good to me but I would recommend to fix the reported sonar issue.

@devinea devinea requested a review from heimwege September 22, 2025 17:17
@devinea
Copy link
Member Author

devinea commented Sep 22, 2025

In general the PR looks good to me but I would recommend to fix the reported sonar issue.

@heimwege sonar issues addressed.

Copy link

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes are straightforward
  • Changeset ok
  • Test coverage good
  • Review comments addressed
  • Did not test manually

Copy link
Member

@vinayhospete vinayhospete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good to me

@devinea devinea merged commit 5591f68 into main Sep 23, 2025
16 checks passed
@devinea devinea deleted the MCP_use_ux_logger branch September 23, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiori-mcp @sap-ux/fiori-mcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants