Skip to content

Conversation

devinea
Copy link
Member

@devinea devinea commented Sep 19, 2025

Update MCP to use snake case instead of kebab case in MCP tool names. Rename doc_search to search_docs.

Copy link

changeset-bot bot commented Sep 19, 2025

🦋 Changeset detected

Latest commit: 8a9719a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege added the fiori-mcp @sap-ux/fiori-mcp label Sep 20, 2025
@heimwege
Copy link
Contributor

heimwege commented Sep 20, 2025

The tool names are part of the readme.md as well. Please also update the names in this file.

@devinea
Copy link
Member Author

devinea commented Sep 22, 2025

The tool names are part of the readme.md as well. Please also update the names in this file.

Thanks @heimwege . Updated in 1deaf75

@devinea devinea requested a review from heimwege September 22, 2025 10:51
Copy link

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changes are straightforward
  • did NOT change manually
  • changeset ok
  • test coverage ok
  • review comments have been addressed

Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. code changes are straightforward - ids of tools are renamed
  2. tests are adjusted
  3. changelog persists

@devinea devinea merged commit f3768a9 into main Sep 22, 2025
18 of 24 checks passed
@devinea devinea deleted the mcp_align_tool_names branch September 22, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiori-mcp @sap-ux/fiori-mcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants