Skip to content

Conversation

johannes-kolbe
Copy link
Contributor

Fixes small cli text display while asking for configuration source {{-type}} {{-file}}
Screenshot 2025-09-19 at 10 29 44

Copy link

changeset-bot bot commented Sep 19, 2025

🦋 Changeset detected

Latest commit: df8fb63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/app-config-writer Patch
@sap-ux/create Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@openuxtools-bot openuxtools-bot marked this pull request as ready for review September 19, 2025 11:20
@heimwege heimwege added the app-config-writer @sap-ux/app-config-writer label Sep 20, 2025
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and text adjustment lgtm
Did not test manually
Changeset ok
Test coverage ok

Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. code change to set empty string for i18n template variable is straightforward
  2. test adjusted
  3. changelog exists

Copy link

@johannes-kolbe johannes-kolbe merged commit 99155bf into main Oct 14, 2025
16 checks passed
@johannes-kolbe johannes-kolbe deleted the fix/smartlinks/prompt branch October 14, 2025 12:30
devinea added a commit that referenced this pull request Oct 15, 2025
…chart_on_list_v4

* origin/main:
  chore: apply latest changesets
  feat(fpm-writer): table building block custom columns (#3665)
  chore: apply latest changesets
  fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706)
  chore: apply latest changesets
  fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times.  (#3683)
  chore: apply latest changesets
  update axios version (#3732)
  chore: apply latest changesets
  fix(fiori-annotation-api): wrong origin range (#3729)
  chore: apply latest changesets
  TBI - Replace service key (UAA/OAuth2) based connections with re-entrance tickets (#3693)
  chore: apply latest changesets
  fix: smartlinks target prompt (#3643)
  chore: apply latest changesets
  feat: Add ADP Generator Cloud Foundry prompting code (#3518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-config-writer @sap-ux/app-config-writer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants