Skip to content

Conversation

voicis
Copy link
Contributor

@voicis voicis commented Sep 18, 2025

In CAP CDS annotations with shortcut syntax can occur before actual values, but this was not correctly handled when merging, because we expected that all annotations should have values which is not correct.

  • Fixed annotation value/collection/record not being merged if it was not the first reference for that target/term/qualifier in that file
  • Fixed issue where origins were not correctly updated when merging annotations
  • Replaced console.log with proper logger calls

@voicis voicis requested a review from a team as a code owner September 18, 2025 13:21
@voicis voicis added the fiori-annotation-api @sap-ux/fiori-annotation-api label Sep 18, 2025
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: ec7f227

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sap-ux/fiori-annotation-api Patch
@sap-ux/annotation-generator Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Covered by tests
Didn't test locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiori-annotation-api @sap-ux/fiori-annotation-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants