Skip to content

Conversation

marianfoo
Copy link
Contributor

Add hint for MCP Readme file to AGENTS.md like in UI5 MPC and CAP MCP Server

Copy link

changeset-bot bot commented Sep 12, 2025

⚠️ No Changeset found

Latest commit: 4aca7f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cla-assistant bot commented Sep 12, 2025

CLA assistant check
All committers have signed the CLA.

@heimwege heimwege added the fiori-mcp @sap-ux/fiori-mcp label Sep 12, 2025
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit that I'm not super happy with that sentence because agents.md is not yet a global standard so there might be agents that simply don't support it (yet). But for the sake of consistency and the hope of it becoming a standard quite soon, I approve.

@marianfoo did you skip the creation of a changeset on purpose? w/o changeset there will be no new npmjs version for this change.

@marianfoo
Copy link
Contributor Author

It's just the same sentence as in the other SAP MCP Server
I did skip on purpose as you ship it soon again, is this fine?

@heimwege
Copy link
Contributor

heimwege commented Sep 12, 2025

It's just the same sentence as in the other SAP MCP Server
I did skip on purpose as you ship it soon again, is this fine?

Sure, I just wanted to confirm that it was on purpose.

FYI: I just pinged @donal-tobin-sap to check the pipeline issue as it does not seem to be caused by your change 😺

@marianfoo
Copy link
Contributor Author

would be a flimsy pipeline if it breaks with a readme change 😄

@marianfoo
Copy link
Contributor Author

@heimwege

I have to admit that I'm not super happy with that sentence because agents.md is not yet a global standard so there might be agents that simply don't support it (yet).

What i did not mention, what triggered this PR is that VS Code has now support for AGENTS.md. You might have seen it. So it is maybe not yet standard, but it is going to if VS Code supports its too.

@heimwege
Copy link
Contributor

Hi @marianfoo,
back from vacation I just learned that SonarCloud does not support analyzes external Pull Request (link). So let me create an internal branch and 🍒-pick your changes so that we get it in, while we are searching for a solution to better handle 3rd party contributions 🙈 Sorry for the inconvenience.

@heimwege
Copy link
Contributor

🍒-picked the changes to an internal branch (PR #3657) to be able to run SonarCloud checks.

@heimwege heimwege closed this Sep 22, 2025
@marianfoo
Copy link
Contributor Author

Oh yeah, had the same problem in SAP/open-ux-odata#940
It is just a security issues as i could have code in there to show secrets from the repo, so it is not a bug but a feature.
As it seems you dont get that many outside contributions anyway it seems like it is not a big problem?

@heimwege
Copy link
Contributor

We (sadly) don't get may at the moment, that's correct. But I want this number to increase in future. Therefor the convenience for the contributor should be given and the additional effort for us should be minimized.
But yes doing this via cherry-pick was quite straightforward.
Let's hope that SonarCloud supports monorepos with the automatic analysis in the future as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiori-mcp @sap-ux/fiori-mcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants