fix: 🐛 [IOSSDKBUG-991] revert segment control style in swift5 #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyu0722
force-pushed
the
fix-IOSSDKBUG-991
branch
from
cf2ef66 to
e257c56
Compare
dyongxu
requested changes
Oct 22, 2025
| if #available(iOS 26.0, *) { | ||
| return Capsule() | ||
| } else { | ||
| #if swift(>=6.0) |
There was a problem hiding this comment.
Our SDK is using Swift compiler 5.9. (See Package.swift, the first line)
Mobile Start team consumes it as binary framework(not source code)
That means, our binary framework will always return RoundedRectangle(cornerRadius: 9) at line 62. No capsule will be returned at all.
For Mobile Start team, even if they use Swift compiler 6.0, they will not reach the "if" side of the code.
xiaoyu0722
force-pushed
the
fix-IOSSDKBUG-991
branch
from
4ff5b63 to
db87030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.