Feat: Allow generation and veryfying groth16 proofs to enable compatiblity between sp1 versions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0rek
commented
Jan 23, 2025
program/src/main.rs
Outdated
| // https://docs.rs/sp1-prover/3.0.0-rc1/src/sp1_prover/types.rs.html#56 | ||
| let vkey_digest_bn254 = babybears_to_bn254(&proof_vkey_hash); | ||
| let vkey_digest_bytes32 = format!("0x{:0>64}", vkey_digest_bn254.as_canonical_biguint().to_str_radix(16)); | ||
| Groth16Verifier::verify(&proof, &recursive_input.public_values, &vkey_digest_bytes32, &sp1_key).expect("groth16 verification failed"); |
Author
There was a problem hiding this comment.
SP1 key is read from the input, but the program vkey is either hardcoded one of the v1 ELF, or current one; so this seems safe?
zvolin
reviewed
Jan 23, 2025
flake.nix
Outdated
|
|
||
| RUSTC_VERSION = overrides.toolchain.channel; | ||
|
|
||
| # https://github.com/rust-lang/rust-bindgen#environment-variables |
There was a problem hiding this comment.
I think this and further magic you do to make bindgen work nice can be achieved by just adding pkgs.rustPlatform.bindgenHook to build inputs
zvolin
reviewed
Jan 23, 2025
flake.nix
Outdated
| buildInputs = with pkgs; [ | ||
| clang | ||
| llvmPackages.bintools | ||
| rustup |
There was a problem hiding this comment.
I think you should just use Fenix instead, it has fromRustToolchainFile or similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more robust testing and cleanup. Program part should be mostly done, wanted to share and get early comments.