Expand xattr tests for RsyncProject/rsync#766 #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file have many xattrs that the sum of all attribute names is larger than 1024, rsync will fail.
rosorio
force-pushed
the
286773-xattr-fix
branch
from
8b9b324 to
8e1fcb7
Compare
|
Apparently cygwin doesn't support long xattrs so for now skip the test for this platform |
First pach to extend xattr buffer makes rsync fail when copy files without xattr such as fifo. Extend the test to ensure new patch work as expected Use checktee instead of checkit because gnu diff fails comparing fifos.
rosorio
force-pushed
the
286773-xattr-fix
branch
from
991a808 to
7a12971
Compare
|
Apparently new test on pipes fails on dir-diff for cygwin, but I don't know how to test that. |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 29, 2025
Fix sys_llistxattr() for FreeBSD code to request a larger buffer to store the extended attributes list if the current one is too small. I also improve the attribute parsing by reducing to one the memmove calls when converting FreeBSD attribute list to the format used by Linux and extend the rsync unit tests for long xattrs lists. Changes where submitted to upstream as: RsyncProject/rsync#781 RsyncProject/rsync#766 PR: 286773 Reported by: Peter Eriksson <[email protected]> Obtained from: Peter Eriksson <[email protected]> Reviewed by: rodrigo Tested by: rodrigo Event: Berlin Hackaton 202507 Relnotes: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file have many xattrs that the sum of all
attribute names is larger than 1024, rsync transfer will fail.
This issue was fixed by #766