Issue #4469 no more mail internet take 5 #4605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get the header object always from MIME::Entity instance parsing is now done exclusively with MIME::Parser decoding the transfer encoding is now done with bodyhandle->as_string consistently pass a string ref to MIME::Parser, as passing an arrayref is deprecated
this is the old default when Mail::Internet was used one effect is that trailing spaces are removed
'Email' was a Mail::Internet from which the body was available directly. For the sake of the test we use now the ParserParts object for looping over the parts.
Only Mail::Internet automatically adds the newlines. Fix the test by passing the complete string.
the Email was read as an array of lines with the trailing newlines A header was added without the newline, which broke the header of the mail
The attribute 'Email' was removed, it used to hold an instance of Mail::Internet
Passing a stringref Kernel::System::PostMaster::new() instead of an arrayref. This avoids the work to join the array into a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase the branch on rel-11_1. Squashed the initial two commits as they did closely related things.