Fix dropped settings issues in HighResDocker #520
+3
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy constructor of HighResDocker was not copying over the resfile_ member, which means it was ignoring that setting. Since the copy constructor is effectively a straight member-by-member copy, we can simply delete it and rely on the autogenerated copy constructor. Additionally, I noticed that the initialize_from_options() function was declaring local variables, rather than changing the member variables. Fix this.
roccomoretti
added
ready_for_review
tydingcw
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy constructor of HighResDocker was not copying over the resfile_ member, which means it was ignoring that setting. Since the copy constructor is effectively a straight member-by-member copy, we can simply delete it and rely on the autogenerated copy constructor.
Additionally, I noticed that the initialize_from_options() function was declaring local variables, rather than changing the member variables. Fix this.