Fix: Conditionally pass idx_pdb to writepdb to avoid AttributeError with SelfConditioning/ScaffoldedSampler #409
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since ScaffoldedSampler.sample_init() doesn't set idx_pdb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an AttributeError that occurs when running the example script design_macrocyclic_binder.sh using the SelfConditioning or ScaffoldedSampler samplers.
After PR #348, the code attempted to pass sampler.idx_pdb to the writepdb function, but certain sampler classes (such as SelfConditioning and ScaffoldedSampler) do not always define the idx_pdb attribute. This resulted in a runtime error.
With this change, idx_pdb is only passed to writepdb if the sampler object actually has the attribute.