Skip to content

Conversation

Rohit3523
Copy link
Collaborator

@Rohit3523 Rohit3523 commented Aug 28, 2025

Proposed changes

Right now on mobile, when someone clicks a markdown link we don’t show any alert about where the link will actually take them. This can be misleading because markdown allows hiding the real URL behind a safe-looking label, for example [https://a-legit-website.com](https://a-scam-website.com), and we end up rendering only https://a-legit-website.com where the user will not be able to see the actual destination. I have added an alert modal that appears when a user clicks on a link. The modal informs them that they are leaving the app, shows the actual destination URL, and gives them the choice to either continue or cancel. This makes it clear what website they are about to visit, helps prevent accidental clicks and protects against potentially unsafe or disguised links.

Note: The modal will only appear when the user tries to open a link that does not start with the workspace URL. Links that point to messages or rooms within the same workspace will open directly without showing the modal.

Issue(s)

N/A

How to test or reproduce

Just send a link in Direct Message or in a Room

Screenshots

Android iOS
Screenshot 2025-08-28 at 9 27 01 PM Screenshot 2025-08-28 at 9 26 48 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modulesc

@Rohit3523 Rohit3523 had a problem deploying to approve_e2e_testing August 28, 2025 16:52 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to official_android_build August 28, 2025 16:55 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build August 28, 2025 16:55 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build August 28, 2025 16:55 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant