-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feature: Show alert before opening link #6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rohit3523
wants to merge
11
commits into
develop
Choose a base branch
from
show-alert-before-opening-link
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Right now on mobile, when someone clicks a markdown link we don’t show any alert about where the link will actually take them. This can be misleading because markdown allows hiding the real URL behind a safe-looking label, for example
[https://a-legit-website.com](https://a-scam-website.com)
, and we end up rendering onlyhttps://a-legit-website.com
where the user will not be able to see the actual destination. I have added an alert modal that appears when a user clicks on a link. The modal informs them that they are leaving the app, shows the actual destination URL, and gives them the choice to either continue or cancel. This makes it clear what website they are about to visit, helps prevent accidental clicks and protects against potentially unsafe or disguised links.Note: The modal will only appear when the user tries to open a link that does not start with the workspace URL. Links that point to messages or rooms within the same workspace will open directly without showing the modal.
Issue(s)
N/A
How to test or reproduce
Just send a link in Direct Message or in a Room
Screenshots
Types of changes
Checklist