Skip to content

fix: set cookie without port in JitsiMeetView to fix #5852 #6507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bezaleelcheung
Copy link

Fixes #5852

Problem

When opening a Jitsi meeting in the Rocket.Chat React Native app, users see a green preloader and never actually join the call when using a custom Jitsi server with a non-standard HTTPS port (e.g., 8443 instead of 443).

This regression was introduced by the fix for #2286, specifically in PR #5458, which added cookie support to the JitsiMeetView component.

Root Cause

The code uses the full meeting URL to extract the cookie domain. However, when the Jitsi server is running on a non-default HTTPS port, the extracted domain includes the port (e.g., example.com:8443), which is not a valid domain for setting a cookie. Per the HTTP cookie spec, the domain should not include the port.

As a result, setting the cookie fails silently, and the JitsiMeetView fails to join the meeting.

Fix

This PR ensures that the cookie domain passed to JitsiMeetView never includes a port number, even when the meeting URL uses a custom port.

Testing

Tested with both:

  • Standard Jitsi server at https://meet.jit.si (port 443)
  • Custom Jitsi server at https://example.com:8443

In both cases, meetings can now be joined successfully.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2025

CLA assistant check
All committers have signed the CLA.

@bezaleelcheung bezaleelcheung force-pushed the fix/jitsi-cookie-port-issue-5852 branch from 1d3ab4d to 4c09583 Compare July 27, 2025 16:16
@OtavioStasiak OtavioStasiak requested a deployment to official_android_build July 29, 2025 14:22 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_android_build July 29, 2025 14:22 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak temporarily deployed to experimental_ios_build July 29, 2025 14:22 — with GitHub Actions Inactive
@bezaleelcheung
Copy link
Author

@OtavioStasiak I see the circleCI error log in “BUild IOS Experimental” :
OpenSSL::PKey::ECError: [!] invalid curve name
Is there anything I can do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile App show green preloader on "Join" to call
3 participants