Skip to content

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 5, 2025

Instead of fetching everything and then digging around in the output base to find magic-named json files, instead we list the required files explicitly as BUILD dependencies so that we'll fail-fast and so that we don't find stale json files from older revisions of Drake.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added release notes: none This pull request should not be mentioned in the release notes priority: low labels Oct 5, 2025
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-noble-unprovisioned-gcc-bazel-experimental-mirror-to-s3

@tyler-yankee
Copy link
Contributor

@drake-jenkins-bot linux-noble-unprovisioned-gcc-bazel-experimental-mirror-to-s3

(I have a PR coming with the docs on this delay ... using this as an example because (a) I noticed it didn't trigger as you'd expected and (b) it's a good chance to remind myself of the language Jenkins uses on the statuses).

@tyler-yankee
Copy link
Contributor

(Ah, the "please" would help...)

@drake-jenkins-bot linux-noble-unprovisioned-gcc-bazel-experimental-mirror-to-s3 please.

@jwnimmer-tri
Copy link
Collaborator Author

+assignee:@Aiden2244 for feature review (or delegation), please?

Copy link
Contributor

@Aiden2244 Aiden2244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Ran the new_release script on this branch and everything is working as expected.

+a:@sammy-tri for platform review (per schedule), please.

@Aiden2244 reviewed 73 of 73 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee sammy-tri(platform)

@sammy-tri sammy-tri assigned rpoyner-tri and unassigned sammy-tri Oct 6, 2025
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to spill this, running out of time for today. -a:@sammy-tri +a:@rpoyner-tri

Reviewable status: LGTM missing from assignee rpoyner-tri(platform)

Instead of fetching everything and then digging around in the output
base to find magic-named json files, instead we list the required
files explicitly as BUILD dependencies so that we'll fail-fast and so
that we don't find stale json files from older revisions of Drake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants