Skip to content

[common] Avoid make_coherent in autodiff #23528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2025
+10 −4
Merged

[common] Avoid make_coherent in autodiff #23528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions common/autodiff_overloads.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,19 @@ pow(const Eigen::AutoDiffScalar<DerTypeA>& base,
typename internal::remove_all<DerTypeA>::type::PlainObject,
typename internal::remove_all<DerTypeB>::type::PlainObject>,
"The derivative types must match.");

internal::make_coherent(base.derivatives(), exponent.derivatives());
using DerType = typename internal::remove_all<DerTypeB>::type::PlainObject;

const auto& x = base.value();
const auto& xgrad = base.derivatives();
const DerType& xgrad = base.derivatives();
const auto& y = exponent.value();
const auto& ygrad = exponent.derivatives();
const DerType& ygrad = exponent.derivatives();

// Make the derivative sizes coherenent.
if (xgrad.size() == 0 && ygrad.size() > 0) {
return pow(MakeAutoDiffScalar(x, DerType::Zero(ygrad.size())), exponent);
} else if (xgrad.size() > 0 && ygrad.size() == 0) {
return pow(base, MakeAutoDiffScalar(y, DerType::Zero(xgrad.size())));
}

using std::log;
using std::pow;
Expand Down