Fix Eigen-related constructor snafus in tests #23526
Merged
+7
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
Eigen 5's simplified constructors now help the compiler flag "unused variable" errors on dead matrices. Similarly, the compiler also flags "uninitialized const" on the default constructor so we need to zero out some test constants.
jwnimmer-tri
force-pushed
the
eigen-5-dead-code
branch
from
fb7ce9f to
c66185d
Compare
jwnimmer-tri
changed the title
|
+@SeanCurtis-TRI for both reviews, please. |
There was a problem hiding this comment.
@SeanCurtis-TRI reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #23477.
This change is