Skip to content

Added min_temp and max_temp configuration options #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jarpatus
Copy link

Added min_temp and max_temp configuration options due to some heat pumps supporting stepping temperature down to 8 degrees instead of separate 8 degrees mode i.e. Innova IWZA09NI-1.

…mps supporting stepping temperature down to 8 degrees instead of separate 8 degrees mode.
@@ -318,6 +323,7 @@ def FetchResult(self, cipher, ip_addr, port, timeout, json):
clientSock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
clientSock.settimeout(timeout)
clientSock.sendto(bytes(json, "utf-8"), (ip_addr, port))
_LOGGER.info('3')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, we do not, seems I did not read my own pull request well enough. This was some leftover debugging code from some previous codebase or something, no need for it. Amended my pull request and removed it.

@RobHofmann
Copy link
Owner

Hey @jarpatus i think we need to update this PR for it to be able to integrate.

Let me know if thats possible and i'll make sure to test & merge it a.s.a.p.

@krzkraw
Copy link

krzkraw commented Jun 17, 2025

@jarpatus @RobHofmann currently my gree cosmo units will continue to cool down room waaay beyond target temp (I set 21, room was chilled to 18). I use external entity to send current room temp to AC and it works I think.
Would merging this PR help with that?

@RobHofmann
Copy link
Owner

@jarpatus @RobHofmann currently my gree cosmo units will continue to cool down room waaay beyond target temp (I set 21, room was chilled to 18). I use external entity to send current room temp to AC and it works I think. Would merging this PR help with that?

No this is about the minimum & maximum value the temperature of the device can be set to. Thats unrelated to "sensing the real tempearture in the room".

@RobHofmann
Copy link
Owner

Just noticed that we also need to make this compatible with the Fahrenheit release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants