add only has more to pagination option #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafaichoi
changed the title
kafaichoi
commented
Feb 3, 2025
| options: options | ||
| }) do | ||
| entries_with_maybe_one_extra = | ||
| entries(query, repo, page_number, page_size, options, extra_entry_size: 1) |
There was a problem hiding this comment.
Here is the core logic where we fetch one more row than it should be.
If the total fetched entries are > page_size, we set has_more to true(and discard the last one from entries). Other, has_more is false
kafaichoi
force-pushed
the
kafai/add-only-has-more-to-pagination-option
branch
from
8c3c4a7 to
b401a60
Compare
update scrivener pointing to river forked one supporting simple page
kafaichoi
force-pushed
the
kafai/add-only-has-more-to-pagination-option
branch
from
b401a60 to
86ebcef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are new test cases. There is no CI setup but u can test existing and new test all pass by
mix testin local