Skip to content

.NET 8 Compatibility #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

.NET 8 Compatibility #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd4546e
Remove build warnings in example apps
Jan 3, 2024
ed829ae
Update NJsonSchema dependencies
Jan 3, 2024
f4e10b1
Bump SigSpec.AspNetCore to net8.0
Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HelloSignalR/HelloSignalR.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't we multi target the project?

</PropertyGroup>
<ItemGroup>
<Folder Include="wwwroot\" />
Expand Down
2 changes: 1 addition & 1 deletion src/SigSpec.AspNetCore/SigSpec.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't we multi target the project?

</PropertyGroup>
<PropertyGroup>
<Owners>Rico Suter</Owners>
Expand Down
4 changes: 2 additions & 2 deletions src/SigSpec.CodeGeneration.CSharp/SigSpec.CodeGeneration.CSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
<EmbeddedResource Include="Templates\Hub.liquid" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="njsonschema.codegeneration" Version="10.7.1" />
<PackageReference Include="njsonschema.codegeneration.csharp" Version="10.7.1" />
<PackageReference Include="njsonschema.codegeneration" Version="11.0.0" />
<PackageReference Include="njsonschema.codegeneration.csharp" Version="11.0.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\SigSpec.CodeGeneration\SigSpec.CodeGeneration.csproj" />
Expand Down
4 changes: 2 additions & 2 deletions src/SigSpec.CodeGeneration.TypeScript/SigSpec.CodeGeneration.TypeScript.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
<EmbeddedResource Include="Templates\Hub.liquid" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="NJsonSchema.CodeGeneration" Version="10.7.1" />
<PackageReference Include="NJsonSchema.CodeGeneration.TypeScript" Version="10.7.1" />
<PackageReference Include="NJsonSchema.CodeGeneration" Version="11.0.0" />
<PackageReference Include="NJsonSchema.CodeGeneration.TypeScript" Version="11.0.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\SigSpec.Core\SigSpec.Core.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion src/SigSpec.CodeGeneration/SigSpec.CodeGeneration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PackageTags>SignalR Specification CodeGeneration</PackageTags>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NJsonSchema.CodeGeneration" Version="10.7.1" />
<PackageReference Include="NJsonSchema.CodeGeneration" Version="11.0.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\SigSpec.Core\SigSpec.Core.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion src/SigSpec.Console/SigSpec.Console.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<AssemblyName>dotnet-sigspec</AssemblyName>
<RootNamespace>SigSpec</RootNamespace>
</PropertyGroup>
Expand Down
5 changes: 3 additions & 2 deletions src/SigSpec.Core/SigSpec.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@
<PackageTags>SignalR Specification CodeGeneration</PackageTags>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NJsonSchema" Version="10.7.1" />
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="NJsonSchema" Version="11.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Microsoft.AspNetCore.SignalR" Version="1.1.0" />
<PackageReference Include="NJsonSchema.NewtonsoftJson" Version="11.0.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/SigSpec.Core/SigSpecDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
using Newtonsoft.Json.Converters;
using Newtonsoft.Json.Serialization;
using NJsonSchema;
using NJsonSchema.Converters;
using System;
using System.Collections.Generic;
using NJsonSchema.NewtonsoftJson.Converters;

namespace SigSpec.Core
{
Expand Down
4 changes: 2 additions & 2 deletions src/SigSpec.Core/SigSpecGeneratorSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
using Newtonsoft.Json;
using Newtonsoft.Json.Serialization;
using NJsonSchema.Generation;
using NJsonSchema.NewtonsoftJson.Generation;

namespace SigSpec.Core
{
public class SigSpecGeneratorSettings : JsonSchemaGeneratorSettings
public class SigSpecGeneratorSettings : NewtonsoftJsonSchemaGeneratorSettings
{
public SigSpecGeneratorSettings()
{
Expand Down