Update nuget packages #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, first check looks very good. |
RicoSuter
reviewed
Jan 29, 2020
| operation.Parameters[arg.Name] = parameter; | ||
| } | ||
|
|
||
| var returnType = |
There was a problem hiding this comment.
Check: This must be a proper contextual type to carry NRT info
There was a problem hiding this comment.
I fixed one bug here, is this what you were thinking of? 793d919
| var hubModel = new HubModel(hub.Key, hub.Value, resolver); | ||
| var template = _settings.TypeScriptGeneratorSettings.TemplateFactory.CreateTemplate("TypeScript", "Hub", hubModel); | ||
| artifacts.Add(new CodeArtifact(hubModel.Name, CodeArtifactType.Class, CodeArtifactLanguage.TypeScript, template)); | ||
| artifacts.Add(new CodeArtifact(hubModel.Name, CodeArtifactType.Class, CodeArtifactLanguage.TypeScript, CodeArtifactCategory.Undefined, template)); |
There was a problem hiding this comment.
I think Client should be good for this, I fixed this.
|
Looks good. Ill check the open comments |
|
Any updates on this? |
|
Ref: #2 (comment) Cant we use .NET Core 3.0 for more compatibility? |
|
@TomSmith27 are there things here we still need to merge? |
|
Looks like this updates to .NET core 3 which could be useful to do however there are conflicts because of the updates i made |
|
Do you still want to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the nuget packages to the latest versions.
NJsonSchema had some interface changes, I'm not sure that I have replaced everything correctly.
I also updated the SignalR version in the Core project, the newer version is part of the aspnet core framework, which can't be referenced in a netstandard project, that's why I changed the targetframeworks. (I couldn't find a workaround to reference the newer version of SignalR without this change.)
The output of the new version is the same, except for this part (
undefined):But according to the C# classes this seems OK to me.