Skip to content

Fix hyperlinks not opening #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

Fix hyperlinks not opening #69

merged 1 commit into from
Aug 24, 2025

Conversation

@Banane9
Copy link
Contributor

@Banane9 Banane9 commented Aug 23, 2025 •
edited
Loading

Fixes #68

@Banane9 Banane9 requested a review from Nytra August 23, 2025 17:56
@Banane9 Banane9 added the bug Something isn't working label Aug 23, 2025
@Nytra
Copy link
Contributor

Nytra commented Aug 23, 2025

Tested it?

@Banane9
Copy link
Contributor Author

Banane9 commented Aug 23, 2025 •
edited
Loading

Yea - this is also how it's done in vanilla now, just minus the http(s) check

@Nytra
Copy link
Contributor

Nytra commented Aug 23, 2025

do you think it could allow code injection?

@Banane9
Copy link
Contributor Author

Banane9 commented Aug 24, 2025

It can still only do things in a protocol://something format, and users have to confirm opening it, so I don't see a risk there tbh. No different than using a browser and clicking some link tied to an application.

@Banane9 Banane9 merged commit e22c685 into master Aug 24, 2025
2 checks passed
@Banane9 Banane9 deleted the fix/hyperlink-opening branch August 24, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nytra Nytra Nytra approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hyperlinks not opening

3 participants

@Banane9 @Nytra