MOD-10712 - Port RM_ScanKey #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust iterator using a KeyScanCursor type add example todo integration tests
…lback, handle reaming review comments
oshadmi
reviewed
Sep 17, 2025
oshadmi
reviewed
Oct 15, 2025
| scan_key( | ||
| self.key.key_inner, | ||
| self.inner_cursor, | ||
| Some(scan_callback::<F>), |
There was a problem hiding this comment.
Doesn't make sense to have no callback, but this is dictated by API, right?
There was a problem hiding this comment.
Yes, it is related to how bindgen auto generates the function pointer types. So it's dictacted by the tool bindgen we use for code generation.
oshadmi
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR got auto-closed and is not re-openable: #419
This PR adds functionality needed by the
LoadDocumentPort in RediSearch.See RediSearch/RediSearch#6509
The main additions:
A wrapper around the RedisModule_ScanKey.
ScanKeyCursorwraps aRedisModule_ScanCursorand ports RedisModule_ScanKeyfor_eachmethod that takes a closureScanKeyCursorUsage to scan_key exampleOther additions:
RedisString::from_raw_partsget_rawto CallReply enum and sub typesRelated PRs
During the CI we run into strange integration test failures, related to side effects that are fixed in the PR: MOD-11364: Improves the robustness of integration tests #425
A breaking change regarding the
enumrepresentation has been split into the PR: Breaking Change Proposal: Replaceisizewithi32oru32as representations for enums. #420